Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[emfcloud-dev] Actions before merging a Pull Request and implicit contribution practices

Hello,

I was reviewing PR https://github.com/eclipse-emfcloud/emfjson-jackson/pull/39

Before merging any PR, I wanted to make sure it wasn't too hasty. So I have a few questions :

  • As a committer, can I directly merge the PR that seems relevant to me, or should I make sure with the rest of the team that it can be inserted in the sprint's scope ? How can I check that the Eclipse Source team is not in the middle of a release process nor in a code freeze ?
  • Is there any manual action I should take regarding https://github.com/orgs/eclipse-emfcloud/projects/2 ? Or is only the project leader in charge of it ?
  • From what I have seen, the practice on the project seem to be to have at least one positive peer-review on the PR, even for committers. Can you confirm that ?

Thank you in advance for the clarifications.

Eventually these answers can be reported to the CONTRIBUTING.md files, like https://github.com/eclipse-emfcloud/emfjson-jackson/blob/master/CONTRIBUTING.md

--

Best regards,

 
CS Group
Linkedin   Youtube
 
Vincent HEMERY
Eclipse and Modeling Expert
BUSINESS UNIT ESPACE
Tel:  +33 561 176 310 / +33 683 931 631
Email:  vincent.hemery@xxxxxxxxxx
 
Speaking at EclipseCon 2021 Speaking at TheiaCon 2021

Back to the top

OSZAR »